GeorgeJahad commented on code in PR #3729:
URL: https://github.com/apache/ozone/pull/3729#discussion_r976850594
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -286,6 +289,25 @@ protected OmMetadataManagerImpl() {
this.omEpoch = 0;
}
+ // metadata constructor for snapshots
+ private OmMetadataManagerImpl(OzoneConfiguration conf, String snapshotName)
+ throws IOException {
+ lock = new OmReadOnlyLock();
+ omEpoch = 0;
+ String snapshotDir = OMStorage.getOmDbDir(conf).toString() +
+ OM_KEY_PREFIX + OM_SNAPSHOT_DIR;
+ setStore(loadDB(conf, new File(snapshotDir),
+ OM_DB_NAME + snapshotName, true));
Review Comment:
Since the UUID is an implementation detail, I'd prefer to call it
snapshotDirName instead of snapshotUUID. Is that acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
