neils-dev commented on code in PR #3728:
URL: https://github.com/apache/ozone/pull/3728#discussion_r978240463
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneKey.java:
##########
@@ -67,14 +70,9 @@ public OzoneKey(String volumeName, String bucketName,
String keyName, long size, long creationTime,
long modificationTime, ReplicationType type,
int replicationFactor) {
- this.volumeName = volumeName;
- this.bucketName = bucketName;
- this.name = keyName;
- this.dataSize = size;
- this.creationTime = Instant.ofEpochMilli(creationTime);
- this.modificationTime = Instant.ofEpochMilli(modificationTime);
- this.replicationConfig = ReplicationConfig.fromTypeAndFactor(type,
- ReplicationFactor.valueOf(replicationFactor));
+ this(volumeName, bucketName, keyName, size, creationTime, modificationTime,
+ ReplicationConfig.fromTypeAndFactor(type,
Review Comment:
Sure @kerneltime, the intialization for the creationTime, modification can
retain its previous initialization prior to the change:
**_previous:_**
```
this.creationTime = Instant.ofEpochMilli(creationTime);
this.modificationTime = Instant.ofEpochMilli(modificationTime);
```
**_now:_**
line 73,
`this(volumeName, bucketName, keyName, size,
`**Instant.ofEpochMilli(creationTime)**,
**Instant.ofEpochMilli(modificationTime),**` ...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
