xBis7 commented on PR #3746: URL: https://github.com/apache/ozone/pull/3746#issuecomment-1256045242
@dombizita `NSSummary` isn't bucket specific. We would have an issue if we were gathering info for volumes but we are dealing with buckets. > NSSummaryTask.process would call eg. first NSSummaryTaskWithFSO.process and after the NSSummaryTaskWithLegacy.process, right? Yes, you are right. This way we can control the order by which we are calling any bucket specific task. `NSSummaryTask.process` will return `new ImmutablePair<>(getTaskName(), true)` after both bucket tasks have finished running and `getTaskName()` will be `NSSummaryTask`. Since `NSSummary` isn't specific to bucket layout and the entries for different layouts won't have an attribute that differentiates them, it seems more clean to have one table instead of two tables with entries of the same type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
