duongkame commented on code in PR #3754:
URL: https://github.com/apache/ozone/pull/3754#discussion_r978058370
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/SecurityConfig.java:
##########
@@ -141,12 +141,15 @@ public SecurityConfig(ConfigurationSource configuration) {
this.certificateFileName = this.configuration.get(HDDS_X509_FILE_NAME,
HDDS_X509_FILE_NAME_DEFAULT);
- this.blockTokenEnabled = this.configuration.getBoolean(
- HDDS_BLOCK_TOKEN_ENABLED,
- HDDS_BLOCK_TOKEN_ENABLED_DEFAULT);
- this.containerTokenEnabled = this.configuration.getBoolean(
- HDDS_CONTAINER_TOKEN_ENABLED,
- HDDS_CONTAINER_TOKEN_ENABLED_DEFAULT);
+// this.blockTokenEnabled = this.configuration.getBoolean(
+// HDDS_BLOCK_TOKEN_ENABLED,
+// HDDS_BLOCK_TOKEN_ENABLED_DEFAULT);
+ this.blockTokenEnabled = false;
Review Comment:
I don't think those changes are supposed to get in.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -493,8 +493,9 @@ private OzoneManager(OzoneConfiguration conf, StartupOption
startupOption)
this.preallocateBlocksMax = conf.getInt(
OZONE_KEY_PREALLOCATION_BLOCKS_MAX,
OZONE_KEY_PREALLOCATION_BLOCKS_MAX_DEFAULT);
- this.grpcBlockTokenEnabled = conf.getBoolean(HDDS_BLOCK_TOKEN_ENABLED,
- HDDS_BLOCK_TOKEN_ENABLED_DEFAULT);
+// this.grpcBlockTokenEnabled = conf.getBoolean(HDDS_BLOCK_TOKEN_ENABLED,
+// HDDS_BLOCK_TOKEN_ENABLED_DEFAULT);
+ this.grpcBlockTokenEnabled = false;
Review Comment:
Please ensure this doesn't get in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
