neils-dev commented on PR #3741: URL: https://github.com/apache/ozone/pull/3741#issuecomment-1258157162
Thanks @errose28 for our offline discussions on this container delete / rename change and for the PR review and comments. > One other thing to check is what happens with schema V3 when the container is moved to the tmp dir but the RocksDB update fails. During the design discussions with @swagle and @nandakumar131 on this case for failed access to db to delete container on container delete operation from, https://github.com/apache/ozone/blob/0e9ea9fba0d78becc393945205fa5450ab31f066/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java#L149 `BlockUtils.removeContainerFromDB(containerData, conf);` it was deemed to be unrecoverable. At the time we called it an unrecoverable error and should the access to delete the container from the db fail, then the disk should be replaced. Right now for that case, we log the error and throw an exception that is translated to a `StorageContainerException`. Presently, there is no recoverable path for the db container delete failure like was discussed in the design discussions. If it should be recoverable, what do you suggest? @swagle , @nandakumar131 thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
