duongkame commented on code in PR #3780:
URL: https://github.com/apache/ozone/pull/3780#discussion_r988528765


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -799,6 +801,34 @@ public OmKeyInfo lookupKey(OmKeyArgs args) throws 
IOException {
     return OmKeyInfo.getFromProtobuf(resp.getKeyInfo());
   }
 
+  @Override
+  public KeyInfoWithVolumeContext getKeyInfo(OmKeyArgs args,

Review Comment:
   It's fair. Yet I think we're trying to deprecate the `lookup` APi and 
replace it with an optimized API. The name `get` sounds more appropriate as 
this API takes a key identifier (vol/bucket/keyname) and returns KeyInfo and it 
does zero lookup/search. 
   How do you think @kerneltime?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to