lokeshj1703 commented on code in PR #3760:
URL: https://github.com/apache/ozone/pull/3760#discussion_r990921893
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteContainerCommandHandler.java:
##########
@@ -67,6 +67,9 @@ public void handle(final SCMCommand command,
final SCMConnectionManager connectionManager) {
final DeleteContainerCommand deleteContainerCommand =
(DeleteContainerCommand) command;
+ if (shouldRequeue(command, context, ozoneContainer)) {
+ context.requeueCommand(command);
+ }
Review Comment:
I think in that case we do not need the requeue functionality. Requeue
itself is a complex mechanism because it will keep occurring in a loop.
Why aren't we blocking the operations on container lock instead of requeue
mechanism? Is it because the handler thread is getting blocked in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
