szetszwo commented on code in PR #3809:
URL: https://github.com/apache/ozone/pull/3809#discussion_r992096099
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1351,13 +1351,10 @@ private void initializeRatisDirs(OzoneConfiguration
conf) throws IOException {
for (File ratisGroupDir : ratisDirFiles) {
if (ratisGroupDir.isDirectory()) {
if (!ratisGroupDir.getName().equals(groupIDfromServiceID)) {
- throw new IOException("Ratis group Dir on disk "
- + ratisGroupDir.getName() + " does not match with
RaftGroupID"
- + groupIDfromServiceID + " generated from service id "
- + getOMServiceId() + ". Looks like there is a change to " +
- OMConfigKeys.OZONE_OM_SERVICE_IDS_KEY + " value after the " +
- "cluster is setup. Currently change to this value is not " +
- "supported.");
+ LOG.warn("Another ratis dir is detected "
Review Comment:
@navinko , thanks for the update. Let's use a similar message for both cases
```java
@@ -1353,16 +1353,13 @@ private void initializeRatisDirs(OzoneConfiguration
conf) throws IOException {
for (File ratisGroupDir : ratisDirFiles) {
if (ratisGroupDir.isDirectory()) {
if (!ratisGroupDir.getName().equals(groupIDfromServiceID)) {
- throw new IOException("Ratis group Dir on disk "
- + ratisGroupDir.getName() + " does not match with
RaftGroupID"
- + groupIDfromServiceID + " generated from service id "
- + getOMServiceId() + ". Looks like there is a change to "
+
- OMConfigKeys.OZONE_OM_SERVICE_IDS_KEY + " value after the
" +
- "cluster is setup. Currently change to this value is not
" +
- "supported.");
+ LOG.warn("Unknown directory {} exists in ratis storage dir
{}."
+ + " It is recommended not to share the ratis storage
dir.",
+ ratisGroupDir, omRatisDir);
}
} else {
- LOG.warn("Unknown file {} exists in ratis storage dir {}",
+ LOG.warn("Unknown file {} exists in ratis storage dir {}. "
+ + " It is recommended not to share the ratis storage dir.",
ratisGroupDir, omRatisDir);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
