aswinshakil commented on code in PR #3818:
URL: https://github.com/apache/ozone/pull/3818#discussion_r992850026
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMBlockDeletingService.java:
##########
@@ -143,10 +147,14 @@ public EmptyTaskResult call() throws Exception {
return EmptyTaskResult.newResult();
}
+ Set<Long> processedTxIDs = new HashSet<>();
for (Map.Entry<UUID, List<DeletedBlocksTransaction>> entry :
transactions.getDatanodeTransactionMap().entrySet()) {
UUID dnId = entry.getKey();
List<DeletedBlocksTransaction> dnTXs = entry.getValue();
+ processedTxIDs.addAll(dnTXs.stream()
Review Comment:
Wouldn't it be better to add this inside `if (!dnTXs.isEmpty())`, So that we
don't have this on empty lists?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
