duongkame commented on code in PR #3800:
URL: https://github.com/apache/ozone/pull/3800#discussion_r993964476
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockInputStream.java:
##########
@@ -302,20 +310,24 @@ protected synchronized int
readWithStrategy(ByteReaderStrategy strategy)
try {
numBytesRead = strategy.readFromBlock(current, numBytesToRead);
retries = 0; // reset retries after successful read
+ } catch (SCMSecurityException ex) {
+ throw ex;
} catch (StorageContainerException e) {
if (shouldRetryRead(e)) {
handleReadError(e);
continue;
} else {
throw e;
}
- } catch (SCMSecurityException ex) {
- throw ex;
} catch (IOException ex) {
// We got a IOException which might be due
// to DN down or connectivity issue.
if (shouldRetryRead(ex)) {
- current.releaseClient();
+ if (isConnectivityIssue(ex)) {
Review Comment:
Added comments along with the updated PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
