GeorgeJahad commented on code in PR #3800:
URL: https://github.com/apache/ozone/pull/3800#discussion_r996179858
##########
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBlockInputStream.java:
##########
@@ -280,35 +284,9 @@ public void testRefreshPipelineFunction() throws Exception
{
}
}
- @Test
- public void testGetBlockInfoFailWithIOException() throws Exception {
- GenericTestUtils.setLogLevel(BlockInputStream.getLog(), Level.DEBUG);
- GenericTestUtils.LogCapturer logCapturer =
- GenericTestUtils.LogCapturer.captureLogs(
- LoggerFactory.getLogger(BlockInputStream.class));
- BlockID blockID = new BlockID(new ContainerBlockID(1, 1));
- AtomicBoolean isRefreshed = new AtomicBoolean();
- createChunkList(5);
- BlockInputStream blockInputStreamWithRetry =
- new DummyBlockInputStreamWithRetry(blockID, blockSize,
- MockPipeline.createSingleNodePipeline(), null,
- false, null, chunks, chunkDataMap, isRefreshed,
- new IOException("unavailable"));
- try {
- Assert.assertFalse(isRefreshed.get());
- byte[] b = new byte[200];
- blockInputStreamWithRetry.read(b, 0, 200);
- // As in case of IOException we do not do do refresh.
- Assert.assertFalse(isRefreshed.get());
- Assert.assertTrue(logCapturer.getOutput().contains(
- "Retry to get chunk info fail"));
Review Comment:
This is the only test that excercises the log, and it's been removed. Is
that a problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
