sumitagrawl commented on PR #3782: URL: https://github.com/apache/ozone/pull/3782#issuecomment-1280012897
> The logic looks good overall. I have some minor comments below. Also, I noticed that there is a lot of repeated code between `TestContainerBalancer` and `TestContainerBalancerTask`. Maybe we can keep the tests in one class? Or avoid redoing the setup logic. TestContainerBalancer is refactored to avoid setting up containerBalancerTask for moveContainer simulation. This is not required and Here need to have some wait for thread running, which is achieved using duTrigger task wait for 60sec, Same is updated in Test setup configuraiton. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
