adoroszlai commented on PR #3803: URL: https://github.com/apache/ozone/pull/3803#issuecomment-1280392957
> owever before doing this change I noticed that same hard coded variable value was being used for all fs operations , I just made it configurable that variable. Pls let me know if I am missing something. Previously there was no precondition check, since the value was hard-coded. Adding a check this way affects all operations, even those that to which page size does not apply. Instead of throwing exception if the page size config exceeds max. allowed, how about limiting it (and maybe logging a warning)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
