kerneltime commented on code in PR #3835:
URL: https://github.com/apache/ozone/pull/3835#discussion_r997596076
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -124,6 +124,10 @@ public class SCMNodeManager implements NodeManager {
private final boolean useHostname;
private final ConcurrentHashMap<String, Set<String>> dnsToUuidMap =
new ConcurrentHashMap<>();
+ private final Map<String, Set<String>> ipAddressToUuidMap =
Review Comment:
I think we should only keep a single map and iterate and filter vs
maintaining each way to list datanodes in memory all the time. It seems
wasteful and prone to bugs on updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
