adoroszlai commented on code in PR #3827:
URL: https://github.com/apache/ozone/pull/3827#discussion_r998531220
##########
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestRDBStoreIterator.java:
##########
@@ -293,4 +298,28 @@ public void testNormalPrefixedIterator() throws
IOException {
iter.close();
}
+
+ @Test
+ public void testGetStackTrace() {
+ ManagedRocksIterator iterator = mock(ManagedRocksIterator.class);
+ RocksIterator mock = mock(RocksIterator.class);
+ when(iterator.get()).thenReturn(mock);
+ when(mock.isOwningHandle()).thenReturn(true);
+ ManagedRocksObjectUtils.assertClosed(iterator);
+ verify(iterator, times(1)).getStackTrace();
Review Comment:
```
M D RV: Return value of
org.apache.hadoop.hdds.utils.db.managed.ManagedRocksIterator.getStackTrace()
ignored, but method has no side effect At TestRDBStoreIterator.java:[line 309]
```
https://github.com/apache/ozone/actions/runs/3271563470/jobs/5382670610#step:7:10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
