sodonnel commented on code in PR #3781:
URL: https://github.com/apache/ozone/pull/3781#discussion_r998652376
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionMetrics.java:
##########
@@ -97,62 +109,138 @@ public void unRegister() {
DefaultMetricsSystem.instance().unregisterSource(METRICS_SOURCE_NAME);
}
- public void setTotalTrackedDecommissioningMaintenanceNodes(
+ public void setTrackedDecommissioningMaintenanceNodesTotal(
long numNodesTracked) {
- totalTrackedDecommissioningMaintenanceNodes
+ trackedDecommissioningMaintenanceNodesTotal
.set(numNodesTracked);
}
- public void setTotalTrackedRecommissionNodes(
+ public void setTrackedRecommissionNodesTotal(
long numNodesTrackedRecommissioned) {
- totalTrackedRecommissionNodes.set(numNodesTrackedRecommissioned);
+ trackedRecommissionNodesTotal.set(numNodesTrackedRecommissioned);
}
- public void setTotalTrackedPipelinesWaitingToClose(
+ public void setTrackedPipelinesWaitingToCloseTotal(
long numTrackedPipelinesWaitToClose) {
- totalTrackedPipelinesWaitingToClose
+ trackedPipelinesWaitingToCloseTotal
.set(numTrackedPipelinesWaitToClose);
}
- public void setTotalTrackedContainersUnderReplicated(
+ public void setTrackedContainersUnderReplicatedTotal(
long numTrackedUnderReplicated) {
- totalTrackedContainersUnderReplicated
+ trackedContainersUnderReplicatedTotal
.set(numTrackedUnderReplicated);
}
- public void setTotalTrackedContainersUnhealthy(
+ public void setTrackedContainersUnhealthyTotal(
long numTrackedUnhealthy) {
- totalTrackedContainersUnhealthy
+ trackedContainersUnhealthyTotal
.set(numTrackedUnhealthy);
}
- public void setTotalTrackedContainersSufficientlyReplicated(
+ public void setTrackedContainersSufficientlyReplicatedTotal(
long numTrackedSufficientlyReplicated) {
- totalTrackedContainersSufficientlyReplicated
+ trackedContainersSufficientlyReplicatedTotal
.set(numTrackedSufficientlyReplicated);
}
- public long getTotalTrackedDecommissioningMaintenanceNodes() {
- return totalTrackedDecommissioningMaintenanceNodes.value();
+ public long getTrackedDecommissioningMaintenanceNodesTotal() {
+ return trackedDecommissioningMaintenanceNodesTotal.value();
}
- public long getTotalTrackedRecommissionNodes() {
- return totalTrackedRecommissionNodes.value();
+ public long getTrackedRecommissionNodesTotal() {
+ return trackedRecommissionNodesTotal.value();
+ }
+
+ public long getTrackedPipelinesWaitingToCloseTotal() {
+ return trackedPipelinesWaitingToCloseTotal.value();
+ }
+
+ public long getTrackedContainersUnderReplicatedTotal() {
+ return trackedContainersUnderReplicatedTotal.value();
+ }
+
+ public long getTrackedContainersUnhealthyTotal() {
+ return trackedContainersUnhealthyTotal.value();
+ }
+
+ public long getTrackedContainersSufficientlyReplicatedTotal() {
+ return trackedContainersSufficientlyReplicatedTotal.value();
+ }
+
+ public void metricRecordPipelineWaitingToCloseByHost(String host,
+ long num) {
+ trackedPipelinesWaitingToCloseByHost.computeIfAbsent(host,
+ hostID -> registry.newGauge(
+ Interns.info("trackedPipelinesWaitingToClose-" + hostID,
+ "Number of pipelines waiting to close for "
+ + "host in decommissioning and "
+ + "maintenance mode"),
+ 0L)
+ ).set(num);
+ }
+
+ public void metricRecordOfReplicationByHost(String host,
+ long sufficientlyReplicated,
+ long underReplicated,
+ long unhealthy) {
+ trackedSufficientlyReplicatedByHost.computeIfAbsent(host,
Review Comment:
Formatting is a bit strange here too. If you indent by 4 instead of 8 I
think we can wrap one less line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
