pratapchandu commented on code in PR #3847:
URL: https://github.com/apache/ozone/pull/3847#discussion_r998950546
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java:
##########
@@ -124,6 +124,15 @@ List<DatanodeDetails> filterViableNodes(
// get nodes in HEALTHY state
List<DatanodeDetails> healthyNodes =
nodeManager.getNodes(NodeStatus.inServiceHealthy());
+ if (healthyNodes.size() < nodesRequired) {
Review Comment:
Two others alternative fixes are working fine
1) changing expected code to FAILED_TO_FIND_NODES_WITH_SPACE in test
https://github.com/apache/ozone/blob/4454e6b368bc5aedaba509eeb85422daeda393bf/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestRatisPipelineCreateAndDestroy.java#L148
But is it ok to expect FAILED_TO_FIND_NODES_WITH_SPACE after shutting
down all data nodes ?
@aswinshakil is this same as the change tried by you ?
2) Removing assertEquals on result code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
