sumitagrawl commented on code in PR #3783:
URL: https://github.com/apache/ozone/pull/3783#discussion_r999087035
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java:
##########
@@ -518,6 +525,28 @@ private void initializeEventHandlers() {
}
+ @NotNull
+ private List<BlockingQueue<ContainerReportBase>> initContainerReportQueue() {
+ int threadPoolSize = configuration.getInt(OZONE_SCM_EVENT_PREFIX +
+ StringUtils.camelize(SCMEvents.CONTAINER_REPORT.getName()
+ + "_OR_"
+ + SCMEvents.INCREMENTAL_CONTAINER_REPORT.getName())
+ + ".thread.pool.size",
+ OZONE_SCM_EVENT_THREAD_POOL_SIZE_DEFAULT);
+ int queueSize = configuration.getInt(OZONE_SCM_EVENT_PREFIX +
+ StringUtils.camelize(SCMEvents.CONTAINER_REPORT.getName()
+ + "_OR_"
+ + SCMEvents.INCREMENTAL_CONTAINER_REPORT.getName())
+ + ".queue.size",
+ OZONE_SCM_EVENT_CONTAINER_REPORT_QUEUE_SIZE_DEFAULT);
Review Comment:
As discussed,
1.
ozone.scm.event.ContainerReport_or_IncrementalContainerReport.**thread.pool.size**
<-- existing one as earlier used in
FixedThreadPoolWithAffinityExecutor::initializeExecutorPool (Refactored now to
be used for queue creation)
2.
ozone.scm.event.ContainerReport_or_IncrementalContainerReport.**queue.size**
<-- **added now to have bounded queue size** (Earlier its unbounded)
One of Thread Pool --> Have One Container Queue --> can handle multiple DNs
report (including both FCR / ICR)
One DN associated to only one Thread Pool (& its queue), as need execute
FCR/ICR in order of receiving from DN.
So we use both config, Thread pool size is useful for parallelism of
multiple DNs
Queue Size -- max set of FCR/ICR for one or More DN to the executor
pool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
