sodonnel commented on PR #3781: URL: https://github.com/apache/ozone/pull/3781#issuecomment-1283798159
One other thing I spotted: ``` "TrackedPipelinesWaitingToCloseTotal" : 2, "TrackedRecommissionNodesTotal" : 0, "trackedPipelinesWaitingToClose-ozone-datanode-3.ozone_default" : 0, "trackedSufficientlyReplicated-ozone-datanode-3.ozone_default" : 0, "trackedUnderReplicated-ozone-datanode-3.ozone_default" : 0, "trackedUnhealthyContainers-ozone-datanode-3.ozone_default" : 0, ``` The host level metrics start with a lower case letter, but the others start with upper case. We should be consistent here inline with what other metrics do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org