sodonnel commented on code in PR #3851:
URL: https://github.com/apache/ozone/pull/3851#discussion_r999273782
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamProxy.java:
##########
@@ -157,11 +158,17 @@ public synchronized int read(ByteBuffer buf) throws
IOException {
lastPosition = blockReader.getPos();
totalRead += blockReader.read(buf);
}
+ if (reconstructionReader) {
Review Comment:
I wonder if this makes sense? This read method is going to be called for
every read into a file. Eg if something is reading a file 1 byte at a time, it
could be called 100's of times. Would it make more sense to increment just once
when the proxy class sets up the reconstruction reader? Eg in
`createBlockReader()` in the same class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
