dombizita commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r1000239940
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends
React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse =
response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] =
missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
+ axios.get('/api/v1/containers/unhealthy/UNDER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/OVER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/MIS_REPLICATED')
Review Comment:
In what kind of cluster did you get this response? Did you change everything
accordingly to this change? If you don't pass any state as a parameter to the
endpoint it will return all the containers (javadoc on the
`@Path("/unhealthy/{state}")`: `Passing null returns all containers.`) . Based
on the javadoc on the `@Path("/unhealthy")`:
```
* Return
* {@link
org.apache.hadoop.ozone.recon.api.types.UnhealthyContainerMetadata}
* for all unhealthy containers.
```
I am fine if we ask every states endpoint individually for now, but please
change the `MISSING` state ask accordingly to the others
(`/api/v1/containers/unhealthy/MISSING`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
