Galsza commented on code in PR #3788:
URL: https://github.com/apache/ozone/pull/3788#discussion_r1000373288
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -373,11 +368,21 @@ private ContainerCommandResponseProto dispatchRequest(
container.getContainerData().getState() == State.UNHEALTHY);
sendCloseContainerActionIfNeeded(container);
}
-
+ if (cmdType == Type.CreateContainer
+ && result == Result.SUCCESS && dispatcherContext != null) {
+ Preconditions.checkNotNull(dispatcherContext.getContainer2BCSIDMap());
+ container2BCSIDMap.putIfAbsent(containerID, Long.valueOf(0));
+ }
if (result == Result.SUCCESS) {
updateBCSID(container, dispatcherContext, cmdType);
audit(action, eventType, params, AuditEventStatus.SUCCESS, null);
} else {
+ //TODO HDDS-7096:
+ // This is a too general place for on demand scanning.
+ // Create a specific exception that signals for on demand scanning
+ // and move this general scan to where it is more appropriate.
+ // Add integration tests to test the full functionality.
+ OnDemandContainerScanner.scanContainer(container);
Review Comment:
Thank for these observations. As agreed, this is going to be continued in
[HDDS-7096](https://issues.apache.org/jira/browse/HDDS-7096) with the
exceptions. And eventually the other ideas should be implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
