kaijchen commented on PR #3778: URL: https://github.com/apache/ozone/pull/3778#issuecomment-1285479747
Thanks @Xushaohong for updating the patch. Filtering uncommitted blocks in `verifyAndGetKeyLocations` is a good idea. For clearity, it's better to return a `Pair<updatedBlockLocations, uncommittedBlocks>` instead, or create a inner class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
