neils-dev commented on code in PR #3658: URL: https://github.com/apache/ozone/pull/3658#discussion_r1001080048
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SnapshotChainInfo.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.ozone.om; + +/** + * SnapshotChain supporting SnapshotInfo class. + * + * Defines and provides the interface to the SnapshotChainInfo + * entry that comprises a SnapshotChain. + * Getters / setters for current, prev, next element in snapshot chain. + */ +public class SnapshotChainInfo { + private String snapshotID; + private String previousSnapshotID; + private String nextSnapshotID; + + public SnapshotChainInfo(String snapshotID, String prev, String next) { + this.snapshotID = snapshotID; + previousSnapshotID = prev; + nextSnapshotID = next; + } + + public void setNextSnapshotID(String snapsID) { + nextSnapshotID = snapsID; + } + + public void setPreviousSnapshotID(String snapsID) { + previousSnapshotID = snapsID; + } Review Comment: Thanks @smengcl for your review. On this comment, the parameter variable for the methods was originally as you suggested, _**snapshotID**_, however it is the same as a class declared that causes a checkstyle failure : `'snapshotID' hides a field.` For that reason, to avoid this and any confusion, the variable name is simply, `snapsID.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
