siddhantsangwan commented on code in PR #3877:
URL: https://github.com/apache/ozone/pull/3877#discussion_r1004171087
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/health/TestClosingContainerHandler.java:
##########
@@ -153,32 +164,59 @@ public void testUnhealthyRatisReplicaIsNotClosed() {
/**
* Close commands should be sent for Open or Closing replicas.
*/
- @Test
- public void testOpenOrClosingReplicasAreClosed() {
+ @ParameterizedTest
+ @MethodSource("replicationConfigs")
+ public void testOpenOrClosingReplicasAreClosed(ReplicationConfig repConfig) {
Review Comment:
Parameterizing this is a good idea. If I understand correctly, this test
will now run for both EC and RATIS replication configs. If so, we can delete
the next test `testOpenOrClosingRatisReplicasAreClosed()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
