Galsza commented on code in PR #3865:
URL: https://github.com/apache/ozone/pull/3865#discussion_r1004225798
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/TypedTable.java:
##########
@@ -72,9 +73,9 @@
public TypedTable(
Table<byte[], byte[]> rawTable,
CodecRegistry codecRegistry, Class<KEY> keyType,
- Class<VALUE> valueType) throws IOException {
+ Class<VALUE> valueType, boolean statsEnabled) throws IOException {
Review Comment:
Have you considered other ways to avoid passing statsEnabled all the way
through these methods? I'm not sure there is an easier solution, but maybe
creating multiple methods instead of passing the boolean would be clearer.
Another thing to consider is it's not clear now (at least to me) when the
statsEnabled should be true or false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
