sodonnel commented on code in PR #3781: URL: https://github.com/apache/ozone/pull/3781#discussion_r1004471235
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java: ########## @@ -168,6 +225,43 @@ public int getTrackedNodeCount() { return trackedNodes.size(); } + synchronized void setMetricsToGauge() { + metrics.setTrackedContainersUnhealthyTotal(unhealthyContainers); + metrics.setTrackedRecommissionNodesTotal(trackedRecommission); + metrics.setTrackedDecommissioningMaintenanceNodesTotal( + trackedDecomMaintenance); + metrics.setTrackedContainersUnderReplicatedTotal( + underReplicatedContainers); + metrics.setTrackedContainersSufficientlyReplicatedTotal( + sufficientlyReplicatedContainers); + metrics.setTrackedPipelinesWaitingToCloseTotal(pipelinesWaitingToClose); + for (Map.Entry<String, Long> e : + pipelinesWaitingToCloseByHost.entrySet()) { + metrics.metricRecordPipelineWaitingToCloseByHost(e.getKey(), + e.getValue()); + } + for (Map.Entry<String, ContainerStateInWorkflow> e : Review Comment: I'm not sure how the prom end point works. Its not ideal that it keeps the last value pushed, but I am not sure where that code even comes from! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org