k5342 commented on PR #3842: URL: https://github.com/apache/ozone/pull/3842#issuecomment-1291842438
Thank you @sadanand48 for your review. As a principle, we keep S3G behavior to S3 compatible regardless of its bucket type. As a design choice, about the term behavior, I assume we are talking the behavior means about KeyIterator's behavior (not S3G's result). As you said, this patch only supports FSO buckets. I've added a delimiter parameter to the KeyIterator's constructor but it's never used for now. As this initial patch, I thought we don't need to unify behavior because non-recursive call for OBS buckets as it's heavy to introduce and KeyIterator is internal objects. I completely agree with you to unify behavior at KeyIterator interface level. In that case, is that meant to reimplement delimiter-aware filter in OM server-side protocol handlers (or, we can put as another ticket)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
