smengcl commented on code in PR #3821:
URL: https://github.com/apache/ozone/pull/3821#discussion_r1007673031
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -255,6 +268,27 @@ public void start() {
TimeUnit.MILLISECONDS);
}
+ private void stopSyncDataFromOMThread() {
+ scheduler.shutdownNow();
+ LOG.debug("Shutdown the OM DB sync scheduler.");
+ }
+
+ @Override
+ public boolean triggerSyncDataFromOMImmediately() {
+ if (!isSyncDataFromOMRunning.get()) {
+ // We are shutting down the scheduler and then starting another one,
+ // so we can set the initialDelay to 0, which indicates an OM DB sync
Review Comment:
nit
```suggestion
// setting the initialDelay to 0, which trigger an OM DB sync
```
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -255,6 +268,27 @@ public void start() {
TimeUnit.MILLISECONDS);
}
+ private void stopSyncDataFromOMThread() {
+ scheduler.shutdownNow();
+ LOG.debug("Shutdown the OM DB sync scheduler.");
+ }
+
+ @Override
+ public boolean triggerSyncDataFromOMImmediately() {
+ if (!isSyncDataFromOMRunning.get()) {
+ // We are shutting down the scheduler and then starting another one,
+ // so we can set the initialDelay to 0, which indicates an OM DB sync
Review Comment:
nit
```suggestion
// setting the initialDelay to 0, which triggers an OM DB sync
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
