dombizita commented on code in PR #3868:
URL: https://github.com/apache/ozone/pull/3868#discussion_r1007883287
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/utils/autoReloadHelper.tsx:
##########
@@ -49,6 +49,10 @@ class AutoReloadHelper {
this.stopPolling();
}
};
+
+ toggleChecking = (checked: boolean) => {
+ sessionStorage.setItem('toggleCheck', JSON.stringify(checked));
+ };
Review Comment:
There is basically no difference, I just thought that with the approach I
suggested we can avoid adding and passing another method between the pages with
the same parameter. Also I think this one line that is in the method fits in
the already existing one, the naming isn't confusing either, the functionality
of `handleAutoReloadToggle` should be handling that toggle, so that storage
setting is okay there I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
