aswinshakil commented on code in PR #3790:
URL: https://github.com/apache/ozone/pull/3790#discussion_r1008478180
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientUtils.java:
##########
@@ -212,15 +213,15 @@ public static FileChecksum
getFileChecksumWithCombineMode(OzoneVolume volume,
.setRefreshPipeline(true).setSortDatanodesInPipeline(true)
.setLatestVersionLocation(true).build();
OmKeyInfo keyInfo = rpcClient.getOzoneManagerClient().lookupKey(keyArgs);
-
- // TODO: return null util ECFileChecksum is implemented.
+ BaseFileChecksumHelper helper;
if (keyInfo.getReplicationConfig()
.getReplicationType() == HddsProtos.ReplicationType.EC) {
- return null;
Review Comment:
Yes sounds good, will add that as well with the other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
