sumitagrawl commented on code in PR #3853:
URL: https://github.com/apache/ozone/pull/3853#discussion_r1006685286


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -519,6 +519,20 @@ public final class OzoneConfigKeys {
 
   public static final String OZONE_AUDIT_LOG_DEBUG_CMD_LIST_OMAUDIT =
       "ozone.audit.log.debug.cmd.list.omaudit";
+
+  // Items listing page size for fs client sub-commands output
+  public static final String
+      OZONE_FS_LISTING_PAGE_SIZE = "ozone.fs.listing.page.size";
+
+  public static final int
+      OZONE_FS_LISTING_PAGE_SIZE_DEFAULT = 1024;
+
+  public static final int
+      OZONE_FS_MAX_LISTING_PAGE_SIZE = 5000;

Review Comment:
   This is default conf for OM side as max limit, rename variable accordingly



##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3358,5 +3358,25 @@
     </description>
   </property>
 
+  <property>
+    <name>ozone.fs.listing.page.size</name>
+    <value>1024</value>
+    <tag>OZONE, CLIENT</tag>
+    <description>
+      Listing page size value used by client for listing number of items on fs 
related sub-commands output.
+      Kindly set this config value responsibly to avoid high resource usage. 
Maximum value restricted is 5000 for
+      optimum performance.
+    </description>
+  </property>
 
+  <property>
+    <name>ozone.fs.listing.page.size.max</name>

Review Comment:
   conf name should specify if its client configuration or om configuration at 
server
   like ozone.om.fs.listing.page.size



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to