kaijchen commented on PR #3924: URL: https://github.com/apache/ozone/pull/3924#issuecomment-1299620052
Thanks @jojochuang for the review. > If it is to be included in 1.3.0, has it been stress tested under load? I have run several tests (about 1TB data), and it looks good. > Fix FIFO compaction causing corruption of overlapping seqnos in L0 files due to ingesting files of overlapping seqnos with memtable's under CompactionOptionsFIFO::allow_compaction=true or CompactionOptionsFIFO::age_for_warm>0 or CompactRange()/CompactFiles() is used. Before the fix, force_consistency_checks=true may catch the corruption before it's exposed to readers, in which case writes returning Status::Corruption would be expected. > We do use CompactRange() API in Ozone. So watch out. Looking into the commit for the fix https://github.com/facebook/rocksdb/commit/fc74abb436c5807e967aecc892bb8fa127f2fa85, I'm not sure if this problem is introduced in recent releases. It might exist at the current version (7.4.5) we are using as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
