[
https://issues.apache.org/jira/browse/HDDS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628718#comment-17628718
]
pratap chandu commented on HDDS-3419:
-------------------------------------
Existing code is not checking required condition healthyNodes.size() <
nodesRequired (where new check was added in the current change) before calling
filterNodesWithSpace.
filterNodesWithSpace checking the condition and throwing the exception with
code FAILED_TO_FIND_NODES_WITH_SPACE.
[ozone/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java|https://github.com/apache/ozone/blob/1ff97328b7de88bc35c1665f1c90c0782b3cf7e2/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java#L241]
Line 241 in
[1ff9732|https://github.com/apache/ozone/commit/1ff97328b7de88bc35c1665f1c90c0782b3cf7e2]
||SCMException.ResultCodes.FAILED_TO_FIND_NODES_WITH_SPACE);|
[ozone/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestRatisPipelineCreateAndDestroy.java|https://github.com/apache/ozone/blob/4454e6b368bc5aedaba509eeb85422daeda393bf/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestRatisPipelineCreateAndDestroy.java#L148-L149]
Test is failing with the following assert failure :
[ERROR]
org.apache.hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestroy.testPipelineCreationOnNodeRestart
Time elapsed: 55.337 s <<< FAILURE!
java.lang.AssertionError: expected:<FAILED_TO_FIND_SUITABLE_NODE> but
was:<FAILED_TO_FIND_NODES_WITH_SPACE>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:120)
at org.junit.Assert.assertEquals(Assert.java:146)
at
org.apache.hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestroy.testPipelineCreationOnNodeRestart(TestRatisPipelineCreateAndDestroy.java:146
> Enable TestRatisPipelineCreateAndDestroy test cases
> ---------------------------------------------------
>
> Key: HDDS-3419
> URL: https://issues.apache.org/jira/browse/HDDS-3419
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: test
> Affects Versions: 0.5.0
> Reporter: Nandakumar
> Assignee: pratap chandu
> Priority: Major
> Labels: pull-request-available
>
> Fix and enable TestRatisPipelineCreateAndDestroy test cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
