adoroszlai commented on PR #3925: URL: https://github.com/apache/ozone/pull/3925#issuecomment-1303049457
> would shading be a better approach? I don't think shading helps here. We need this Hadoop-specific package name to access some protected members in some Hadoop classes in the same package. The only real code in this package is the utility to access the Hadoop code. If we shade the Ozone's classes in this package then I don't think it will be able to access Hadoop classes. If we shade both Hadoop and Ozone, we're back to duplicate package-info class. The other possible solution is to copy all related code from Hadoop, but I think the goal in this case was to avoid that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
