xBis7 commented on PR #3878:
URL: https://github.com/apache/ozone/pull/3878#issuecomment-1303119481
@kerneltime @duongkame Thanks for taking a look at the patch.
> I think there was intent in the original metric, and this comes from being
able to diagnose which application/user is seeing what metric.
I agree, that's why there are no functional changes. The metric that gets
passed back and forth is exactly the same and we are only filtering how the
endpoint presents it, like
[here](https://github.com/xBis7/ozone/blob/master/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/PrometheusMetricsSink.java#L117-L120)
with the RocksDb metrics.
> Is this for ofs use cases or s3 based access?
It was used with `S3` but it could be for both use cases.
> I still think this should rather be a change in hadoop-common.
That was my first thought but it seems too complex for what we need. We
don't want to change the metric or reduce the times it gets registered. We need
the name to be consistent, so that it's easier to track with a wildcard search
or something like that, but still want to be able to see the user for every
registry.
If you think that's the best, I'm happy to move forward with it. We don't
have to make the change to hadoop-commons but instead have a class in Ozone,
overriding the one from the `jar`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
