ChenSammi commented on code in PR #3930:
URL: https://github.com/apache/ozone/pull/3930#discussion_r1015367083
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsConfigKeys.java:
##########
@@ -184,6 +184,16 @@ public final class HddsConfigKeys {
// Default Certificate duration to one year.
public static final String HDDS_X509_DEFAULT_DURATION_DEFAULT = "P365D";
+ /**
+ * Duration in days within which before the certificate expiration date the
+ * certificate is automatically renewed.
+ * Default is 28 days.
+ */
+ public static final String HDDS_X509_RENEW_GRACE_DURATION =
+ "hdds.x509.renew.grace.duration";
+
+ public static final String HDDS_X509_RENEW_GRACE_DURATION_DEFAULT = "28";
Review Comment:
Suggest change 28 -> 28D, use Duration as the type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
