xBis7 commented on code in PR #3741:
URL: https://github.com/apache/ozone/pull/3741#discussion_r1015455413
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/VersionEndpointTask.java:
##########
@@ -122,6 +124,19 @@ private void checkVolumeSet(MutableVolumeSet volumeSet,
boolean result = StorageVolumeUtil.checkVolume(volume,
scmId, clusterId, configuration, LOG,
ozoneContainer.getDbVolumeSet());
+
+ // Clean <HddsVolume>/tmp/container_delete_service dir.
+ if (volume instanceof HddsVolume) {
Review Comment:
> I would say to not fail the volume, as the tmp dir being clean on startup
is not required for functionality.
Tmp dir will also be cleaned on shutdown. I agree, let's leave it as it and
just `LOG.error()` upon catching the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
