duongkame commented on PR #3508: URL: https://github.com/apache/ozone/pull/3508#issuecomment-1306380508
As @errose28 already pointed out as per HDDS-6931, the common theme of the problems is: pre-process validation should only perform logic on data which is not supposed to change between pre-process and actual execution in `validateAndUpdateCache`. Otherwise, that validation should be moved to `validateAndUpdateCache` (and is done together with the actual data change in a proper lock scope) to ensure consistency. This change introduces a new mechanism to solve a rare case when a bucket is re-created between pre-processing (a bucket needs to be empty to be deleted, so this case may not happen in a high concurrency). Why don't we just validate the bucket layout in `validateAndUpdateCache`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
