neils-dev commented on PR #3781:
URL: https://github.com/apache/ozone/pull/3781#issuecomment-1306591369

   Latest push contains both simplification changes to 
`NodeDecommissionMetrics` and `DatanodeAdminMonitorImpl` to use the 
`ContainerStateInWorkflow` inner class and methods.  Thanks for the suggestion. 
 
   Also included is a fix to the jmx by host metrics collected:
   
   > The way I'd expect this to work is we have 1 tag per DN, and then the 4 
metrics (under, sufficiently, pipelines, unhealthy) all sharing that tag.
   
   example with datanode 1 and datanode 3 in decommissioning workflow as 
captured by monitor:
   ```
       "TrackedPipelinesWaitingToCloseTotal" : 4,
       "TrackedContainersUnderReplicatedTotal" : 0,
       "TrackedContainersUnhealthyTotal" : 0,
       "TrackedContainersSufficientlyReplicatedTotal" : 0,
       "tag.datanode.1" : "ozone_datanode_1.ozone_default",
       "tag.Hostname.1" : "f27febaf1870",
       "TrackedPipelinesWaitingToCloseDN.1" : 2,
       "TrackedUnderReplicatedDN.1" : 0,
       "TrackedSufficientlyReplicatedDN.1" : 0,
       "TrackedUnhealthyContainersDN.1" : 0,
       "tag.datanode.2" : "ozone_datanode_3.ozone_default",
       "tag.Hostname.2" : "f27febaf1870",
       "TrackedPipelinesWaitingToCloseDN.2" : 2,
       "TrackedUnderReplicatedDN.2" : 0,
       "TrackedSufficientlyReplicatedDN.2" : 0,
       "TrackedUnhealthyContainersDN.2" : 0
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to