Galsza commented on code in PR #3930:
URL: https://github.com/apache/ozone/pull/3930#discussion_r1016216209
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java:
##########
@@ -657,6 +661,9 @@ protected enum InitCase {
* 2. Generates and stores a keypair.
* 3. Try to recover public key if private key and certificate is present
* but public key is missing.
+ * 4. Checks is the certificate is about to be expired or have already been
Review Comment:
nit: typo in Checks is -> it should be Checks if
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/SecurityConfig.java:
##########
@@ -216,6 +223,16 @@ public Duration getDefaultCertDuration() {
return defaultCertDuration;
}
+ /**
+ * Returns the number of days within which before expiration a certificate
Review Comment:
Sorry for missing this, but for consistency's sake could you also change the
description here, how it was done in HddsConfigKeys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
