kerneltime commented on code in PR #2424:
URL: https://github.com/apache/ozone/pull/2424#discussion_r1020978004
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java:
##########
@@ -307,9 +309,29 @@ public OMClientResponse handleWriteRequest(OMRequest
omRequest,
OMClientResponse omClientResponse = null;
omClientRequest =
OzoneManagerRatisUtils.createClientRequest(omRequest, impl);
- omClientResponse = omClientRequest
- .validateAndUpdateCache(getOzoneManager(), transactionLogIndex,
- ozoneManagerDoubleBuffer::add);
+ try {
+ omClientResponse = omClientRequest
+ .validateAndUpdateCache(getOzoneManager(), transactionLogIndex,
+ ozoneManagerDoubleBuffer::add);
+ } catch (InvalidPathException e) {
+ LOG.error("Got InvalidPathException while handling request: {}",
Review Comment:
I don't think we should log to OM log client-induced errors. This could be
something logged to the audit log instead for a failed request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
