kerneltime commented on PR #3915: URL: https://github.com/apache/ozone/pull/3915#issuecomment-1314364423
> > My understanding of the new client.jar should be the same as the original except for shaded protobufs > > However, I opened these two fat jars and found that they did not contain the above two packages. > > The difference is that _usage_ of the protobuf library is shaded vs. not shaded. Protobuf classes are not part of either fat jar, they are provided by users (or the applications they use Ozone with). Why not make the protobuf be part of the shaded client jar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
