smitajoshi12 commented on code in PR #3951:
URL: https://github.com/apache/ozone/pull/3951#discussion_r1022322566


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -1261,336 +1261,8 @@
       "lastUpdatedSeqNumber": 0
     }
   ],
-  "containerUnhealthyMissing": {
-    "missingCount": 0,
-    "underReplicatedCount": 1,
-    "overReplicatedCount": 0,
-    "misReplicatedCount": 0,
-    "containers": [
-      {
-        "containerID": 1,
-        "containerState": "MISSING",
-        "unhealthySince": 1665590446222,
-        "expectedReplicaCount": 3,
-        "actualReplicaCount": 0,
-        "replicaDeltaCount": 3,
-        "reason": null,
-        "keys": 1,
-        "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
-        "replicas": [
-          {
-            "containerId": 2,
-            "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
-            "datanodeHost": "ozone_datanode_2.ozone_missing1",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590397315,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 2,
-            "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
-            "datanodeHost": "ozone_datanode_3.ozone_missing2",
-            "firstSeenTime": 1665588176616,
-            "lastSeenTime": 1665590392293,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 2,
-            "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
-            "datanodeHost": "ozone_datanode_1.ozone_missing3",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590272289,
-            "lastBcsId": 0
-          }
-        ]
-      },
-      {
-        "containerID": 2,
-        "containerState": "MISSING",
-        "unhealthySince": 1665590446222,
-        "expectedReplicaCount": 3,
-        "actualReplicaCount": 0,
-        "replicaDeltaCount": 3,
-        "reason": null,
-        "keys": 1,
-        "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
-        "replicas": [
-          {
-            "containerId": 3,
-            "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
-            "datanodeHost": "ozone_datanode_2.ozone_missing1",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590397315,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 3,
-            "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
-            "datanodeHost": "ozone_datanode_3.ozone_missing2",
-            "firstSeenTime": 1665588176616,
-            "lastSeenTime": 1665590392293,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 3,
-            "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
-            "datanodeHost": "ozone_datanode_1.ozone_missing3",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590272289,
-            "lastBcsId": 0
-          }
-        ]
-      }
-    ]
-  },
-  "containerUnhealthyUnderReplicated": {
-    "missingCount": 0,
-    "underReplicatedCount": 1,
-    "overReplicatedCount": 0,
-    "misReplicatedCount": 0,
-    "containers": [
-      {
-        "containerID": 2,
-        "containerState": "UNDER_REPLICATED",
-        "unhealthySince": 1665590446222,
-        "expectedReplicaCount": 3,
-        "actualReplicaCount": 2,
-        "replicaDeltaCount": 1,
-        "reason": null,
-        "keys": 1,
-        "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
-        "replicas": [
-          {
-            "containerId": 2,
-            "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
-            "datanodeHost": "ozone_datanode_2.ozone_UnderReplicated2",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590397315,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 2,
-            "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
-            "datanodeHost": "ozone_datanode_3.ozone_underreplicated2",
-            "firstSeenTime": 1665588176616,
-            "lastSeenTime": 1665590392293,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 2,
-            "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
-            "datanodeHost": "ozone_datanode_1.ozone_underreplicated2",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590272289,
-            "lastBcsId": 0
-          }
-        ]
-      },
-      {
-        "containerID": 3,
-        "containerState": "UNDER_REPLICATED",
-        "unhealthySince": 1665590446222,
-        "expectedReplicaCount": 4,
-        "actualReplicaCount": 2,
-        "replicaDeltaCount": 2,
-        "reason": null,
-        "keys": 1,
-        "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
-        "replicas": [
-          {
-            "containerId": 3,
-            "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
-            "datanodeHost": "ozone_datanode_2.ozone_underreplicated3",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590397315,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 3,
-            "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
-            "datanodeHost": "ozone_datanode_3.ozone_underreplicated3",
-            "firstSeenTime": 1665588176616,
-            "lastSeenTime": 1665590392293,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 3,
-            "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
-            "datanodeHost": "ozone_datanode_1.ozone_underreplicated3",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590272289,
-            "lastBcsId": 0
-          }
-        ]
-      }
-    ]
-  },
-  "containerUnhealthyOverReplicated": {
-    "missingCount": 0,
-    "underReplicatedCount": 1,
-    "overReplicatedCount": 0,
-    "misReplicatedCount": 0,
-    "containers": [
-      {
-        "containerID": 2,
-        "containerState": "OVER_REPLICATED",
-        "unhealthySince": 1665590446222,
-        "expectedReplicaCount": 3,
-        "actualReplicaCount": 2,
-        "replicaDeltaCount": 1,
-        "reason": null,
-        "keys": 1,
-        "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
-        "replicas": [
-          {
-            "containerId": 2,
-            "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
-            "datanodeHost": "ozone_datanode_2.ozone_overreplicated2",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590397315,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 2,
-            "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
-            "datanodeHost": "ozone_datanode_3.ozone_overreplicated22",
-            "firstSeenTime": 1665588176616,
-            "lastSeenTime": 1665590392293,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 2,
-            "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
-            "datanodeHost": "ozone_datanode_1.ozone_overreplicated2",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590272289,
-            "lastBcsId": 0
-          }
-        ]
-      },
-      {
-        "containerID": 3,
-        "containerState": "OVER_REPLICATED",
-        "unhealthySince": 1665590446222,
-        "expectedReplicaCount": 4,
-        "actualReplicaCount": 2,
-        "replicaDeltaCount": 2,
-        "reason": null,
-        "keys": 1,
-        "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
-        "replicas": [
-          {
-            "containerId": 3,
-            "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
-            "datanodeHost": "ozone_datanode_2.ozone_overreplicated3",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590397315,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 3,
-            "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
-            "datanodeHost": "ozone_datanode_3.ozone_overreplicated3",
-            "firstSeenTime": 1665588176616,
-            "lastSeenTime": 1665590392293,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 3,
-            "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
-            "datanodeHost": "ozone_datanode_1.ozone_overreplicated3",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590272289,
-            "lastBcsId": 0
-          }
-        ]
-      }
-    ]
-  },
-  "containerUnhealthyMisReplicated": {
-    "missingCount": 0,
-    "underReplicatedCount": 1,
-    "overReplicatedCount": 0,
-    "misReplicatedCount": 0,
-    "containers": [
-      {
-        "containerID": 2,
-        "containerState": "MIS_REPLICATED",
-        "unhealthySince": 1665590446222,
-        "expectedReplicaCount": 3,
-        "actualReplicaCount": 2,
-        "replicaDeltaCount": 1,
-        "reason": null,
-        "keys": 1,
-        "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
-        "replicas": [
-          {
-            "containerId": 2,
-            "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
-            "datanodeHost": "ozone_datanode_2.ozone_misreplicated2",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590397315,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 2,
-            "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
-            "datanodeHost": "ozone_datanode_3.ozone_misreplicated2",
-            "firstSeenTime": 1665588176616,
-            "lastSeenTime": 1665590392293,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 2,
-            "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
-            "datanodeHost": "ozone_datanode_1.ozone_misreplicated2",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590272289,
-            "lastBcsId": 0
-          }
-        ]
-      },
-      {
-        "containerID": 3,
-        "containerState": "MIS_REPLICATED",
-        "unhealthySince": 1665590446222,
-        "expectedReplicaCount": 4,
-        "actualReplicaCount": 2,
-        "replicaDeltaCount": 2,
-        "reason": null,
-        "keys": 1,
-        "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
-        "replicas": [
-          {
-            "containerId": 3,
-            "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
-            "datanodeHost": "ozone_datanode_2.ozone_misreplicated3",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590397315,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 3,
-            "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
-            "datanodeHost": "ozone_datanode_3.ozone_misreplicated3",
-            "firstSeenTime": 1665588176616,
-            "lastSeenTime": 1665590392293,
-            "lastBcsId": 2
-          },
-          {
-            "containerId": 3,
-            "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
-            "datanodeHost": "ozone_datanode_1.ozone_misreplicated3",
-            "firstSeenTime": 1665588176660,
-            "lastSeenTime": 1665590272289,
-            "lastBcsId": 0
-          }
-        ]
-      }
-    ]
-  },

Review Comment:
   @smengcl @dombizita 
   
   Yes I forgot to clean up code after 3916.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to