dombizita commented on code in PR #3968:
URL: https://github.com/apache/ozone/pull/3968#discussion_r1024629021
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -1,15 +1,15 @@
{
"clusterState": {
+ "pipelines": 32,
"totalDatanodes": 24,
"healthyDatanodes": 24,
- "pipelines": 32,
"storageReport": {
- "capacity": 32985348833280,
- "used": 15942918602752,
- "remaining": 12094627905536
Review Comment:
Can I ask why did you change this section?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -90,14 +90,12 @@ export class Overview extends
React.Component<Record<string, object>, IOverviewS
});
axios.all([
axios.get('/api/v1/clusterState'),
- axios.get('/api/v1/containers/missing'),
axios.get('/api/v1/task/status')
- ]).then(axios.spread((clusterStateResponse,
missingContainersResponse,taskstatusResponse) => {
+ ]).then(axios.spread((clusterStateResponse, taskstatusResponse) => {
const clusterState: IClusterStateResponse = clusterStateResponse.data;
- const missingContainers: IMissingContainersResponse =
missingContainersResponse.data;
const taskStatus = taskstatusResponse.data;
- const missingContainersCount = missingContainers.totalCount;
+ const missingContainersCount = clusterState.missingContainers;
Review Comment:
Based on the implementation presented in #3952 if the
`clusterState.missingContainers` is 1001, that means we have more than 1000
missing containers in the cluster. We should present this on the UI, if the
count is 1001 we can show eg. `1000+` on the overview page and add some
tooltip, that the user can access the exact number on the Containers page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
