JacksonYao287 commented on code in PR #3963:
URL: https://github.com/apache/ozone/pull/3963#discussion_r1028930184
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java:
##########
@@ -183,6 +194,37 @@ public int getContainerStateCount(final LifeCycleState
state) {
return containerStateManager.getContainerIDs(state).size();
}
+ @Override
Review Comment:
`ReplicationManager#getContainerReplicaCount` uses
`legacyReplicationManager#getContainerReplicaCount` to get
ContainerReplicaCount for ratis container . legacy RM will be removed
ultimately, so `legacyReplicationManager#getContainerReplicaCount` will not
exist.
i suggest to add it to ContainerManager interface for now, since it is a
general interface that we can get container related info without considering
the container type. after removing legacy RM, we can refactor it if needed, and
i think it will not be too much work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
