adoroszlai opened a new pull request, #4000:
URL: https://github.com/apache/ozone/pull/4000
## What changes were proposed in this pull request?
`ReplicationManager` and `LegacyReplicationManager` both define some of the
same configuration keys in their own `ReplicationManagerConfiguration` class.
This results in duplicate items in the generated config:
```
$ grep '<name>hdds.scm.replication'
hadoop-hdds/server-scm/target/classes/ozone-default-generated.xml | sort | uniq
-c
1
<name>hdds.scm.replication.container.inflight.deletion.limit</name>
1
<name>hdds.scm.replication.container.inflight.replication.limit</name>
2 <name>hdds.scm.replication.event.timeout</name>
1
<name>hdds.scm.replication.maintenance.remaining.redundancy</name>
2 <name>hdds.scm.replication.maintenance.replica.minimum</name>
1 <name>hdds.scm.replication.over.replicated.interval</name>
2 <name>hdds.scm.replication.thread.interval</name>
1 <name>hdds.scm.replication.under.replicated.interval</name>
```
In the long run, we are planning to get rid of `LegacyReplicationManager`
completely. In the meantime, we can eliminate the duplication by making
`LegacyReplicationManager` get config values from `ReplicationManager`'s config
where applicable.
https://issues.apache.org/jira/browse/HDDS-7535
## How was this patch tested?
Verified that all keys are still present in the generated config and they
are unique:
```
$ grep '<name>hdds.scm.replication'
hadoop-hdds/server-scm/target/classes/ozone-default-generated.xml | sort | uniq
-c
1
<name>hdds.scm.replication.container.inflight.deletion.limit</name>
1
<name>hdds.scm.replication.container.inflight.replication.limit</name>
1 <name>hdds.scm.replication.event.timeout</name>
1
<name>hdds.scm.replication.maintenance.remaining.redundancy</name>
1 <name>hdds.scm.replication.maintenance.replica.minimum</name>
1 <name>hdds.scm.replication.over.replicated.interval</name>
1 <name>hdds.scm.replication.thread.interval</name>
1 <name>hdds.scm.replication.under.replicated.interval</name>
```
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/3535067762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
