szetszwo commented on code in PR #3974:
URL: https://github.com/apache/ozone/pull/3974#discussion_r1031788998
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestNSSummaryTaskWithFSO.java:
##########
@@ -117,6 +121,9 @@ private TestNSSummaryTaskWithFSO() {
@BeforeClass
public static void setUp() throws Exception {
+ ozoneConfiguration = new OzoneConfiguration();
+ ozoneConfiguration.setLong(OZONE_RECON_NSSUMMARY_FLUSH_TO_DB_MAX_THRESHOLD,
+ 15 * 1000L);
Review Comment:
15k is too big for this test since it won't have 15k objects. Just have
tried with 10 and it worked well! Please use 10. Otherwise, the change won't
be tested.
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -341,6 +343,9 @@ public class TestNSSummaryEndpointWithFSO {
@Before
public void setUp() throws Exception {
+ ozoneConfiguration = new OzoneConfiguration();
+ ozoneConfiguration.setLong(OZONE_RECON_NSSUMMARY_FLUSH_TO_DB_MAX_THRESHOLD,
+ 15 * 1000L);
Review Comment:
15k is too big for this test since it won't have 15k objects. Just have
tried with 10 and it worked well! Please use 10. Otherwise, the change won't
be tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
