sumitagrawl commented on PR #3979: URL: https://github.com/apache/ozone/pull/3979#issuecomment-1328732456
> Thanks @sumitagrawl for filing this jira. A general comment - on the subject of this jira, _Container Report at SCM is not coming separately for ICR and FCR in prometheus endpoint_ . Metrics for the full container report, FCR and the incremental container reports, ICR appear to be collected separately with the `SCMContainerManagerMetrics`. Specifically, the `scm_container_manager_metrics_num_container_reports_processed_successful`, `scm_container_manager_metrics_num_icr_reports_processed_successful`, `scm_container_manager_metrics_num_container_reports_processed_failed`, and `scm_container_manager_metrics_num_icr_reports_processed_failed` are collected and published to the prom endpoint. > > Is this jira for adding additional metrics to be collected and published for FCR and ICR ? Its not about adding new metrics, Its about issue for reporting to prometheus. By default, prometheus endpoint takes classname as key and report metrics. For FCR and ICR, classname is same, so causing to take one of metrics report, other is ignored. So as fix, I am separating the class for metrics for FCR & ICR to resolve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
