GeorgeJahad commented on code in PR #3980:
URL: https://github.com/apache/ozone/pull/3980#discussion_r1034166659
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -3568,7 +3570,7 @@ private DBCheckpoint getDBCheckpointFromLeader(String
leaderId) {
"from the checkpoint.", leaderId);
try {
- return omSnapshotProvider.getOzoneManagerDBSnapshot(leaderId);
+ return omRatisSnapshotProvider.getOzoneManagerDBSnapshot(leaderId);
Review Comment:
I didn't write this code, I just renamed the field. Studying it a bit
further, it does look things will work correctly.
installCheckpoint() will throw an exception, which causes
installSnapshotFromLeader() to return a null TermIndex which is handled in
ratis here:
https://github.com/apache/ratis/blob/release-2.3.0/ratis-server/src/main/java/org/apache/ratis/server/impl/SnapshotInstallationHandler.java#L274-L278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
